Closed
Conversation
`use_inspector` is not available if `HAVE_INSPECTOR` is false. Before this commit, one usage of it would show up as an undeclared identifier (introduced in a766ebf).
addaleax
added
c++
Member
Author
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Member
Author
|
Landed in 0c73c9f |
addaleax
added a commit
that referenced
this pull request
Jun 13, 2016
`use_inspector` is not available if `HAVE_INSPECTOR` is false. Before this commit, one usage of it would show up as an undeclared identifier (introduced in a766ebf). PR-URL: #7258 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 5, 2016
`use_inspector` is not available if `HAVE_INSPECTOR` is false. Before this commit, one usage of it would show up as an undeclared identifier (introduced in a766ebf). PR-URL: #7258 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
src (v8_inspector?)
Description of change
use_inspectoris not available ifHAVE_INSPECTORis false. Before this commit, one usage of it would show up as an undeclared identifier (introduced in a766ebf).